Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated DAO, added migration, model_validator, and pytests #114

Merged
merged 1 commit into from
Mar 13, 2024
Merged

Updated DAO, added migration, model_validator, and pytests #114

merged 1 commit into from
Mar 13, 2024

Conversation

jcadam14
Copy link
Contributor

Closes #113

  • Updated FinancialInstitutionDAO.tax_id to be 10 characters
  • Updated alembic script to change financial_institutions and financial_institutions_history tables tax_id column to be 10 characters
  • Added model_validator to FinancialInstitutionDTO to check regex on tax_id
  • Added pytest to check for invalid tax_id
  • Updated existing tax_id fields in pytests to contain the dash

@jcadam14 jcadam14 self-assigned this Mar 12, 2024
@jcadam14 jcadam14 linked an issue Mar 12, 2024 that may be closed by this pull request
Update tax-id to be 10 characters #113
Closed
@github-actions GitHub Actions
Copy link

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)		Lines missing
  src/entities/models
  dao.py
  dto.py
Project Total  

This report was generated by python-coverage-comment-action

lchen-2101
lchen-2101 approved these changes Mar 13, 2024
View reviewed changes
Copy link
Collaborator

@lchen-2101 lchen-2101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lchen-2101 lchen-2101 merged commit 4f2224b into main Mar 13, 2024
3 checks passed
@lchen-2101 lchen-2101 deleted the 113-update-tax-id-to-be-10-characters branch March 13, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lchen-2101 lchen-2101 lchen-2101 approved these changes

@hkeeler hkeeler Awaiting requested review from hkeeler

@billhimmelsbach billhimmelsbach Awaiting requested review from billhimmelsbach

@nargis-sultani nargis-sultani Awaiting requested review from nargis-sultani

Assignees

@jcadam14 jcadam14

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update tax-id to be 10 characters
2 participants
@jcadam14 @lchen-2101